issue(8448): allow URL with + sign in entry tabs #8508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
Looks good so far to me. Will give it a test later. For the changelog entry look at the others, the Changelog is directed towards end users so something like: We fixed an issue where a plus sign in the url field in the entry editor was breaking links... |
alexandre-cremieux
force-pushed
the
fix-for-issue-8448
branch
from
4423300
to
e480bee
Compare
Siedlerchr
approved these changes
Feb 19, 2022
|
You are welcome. Happy to help. |
koppor
approved these changes
Feb 20, 2022
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java
Outdated
Show resolved
Hide resolved
koppor
requested changes
Feb 20, 2022
* clean code * add java doc * test issue: JabRef#8448
alexandre-cremieux
force-pushed
the
fix-for-issue-8448
branch
from
58f8766
to
cb2fd26
Compare
|
If you can please tell me where I can find the localization script for my understanding ? Thanks |
|
You just have to run the LocalizationConsistencyTest. It will tell you if there are any errors or strings missing/obsolete |
Siedlerchr
approved these changes
Feb 25, 2022
Siedlerchr
added a commit
that referenced
this pull request
Feb 26, 2022
* upstream/main: issue(8448): allow URL with + sign in entry tabs (#8508)
Siedlerchr
added a commit
that referenced
this pull request
Mar 7, 2022
* upstream/main: Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542) Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e Bump classgraph from 4.8.139 to 4.8.141 (#8535) Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536) issue(8448): allow URL with + sign in entry tabs (#8508) Add initial telemetry development documentation (#8530) Add existing "Remote storage" to index Disable telemetry client due to incompatibilites with jakarta (#8526) Update to jakarta xml everywhere and update PDFbox (#8521) Bump flexmark-ext-gfm-tasklist from 0.62.2 to 0.64.0 (#8515) Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519) Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518) Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8448
CleanupUrlFormatterin theorg.jabref.logic.formatter.bibtexfieldspackage. A test with the given case is provided also.Note: please let me know in the PR comments what type of comment you want in
CHANGELOG.mdand if you need a screenshot.CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)